-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show who voted for what in poll results #28305
base: develop
Are you sure you want to change the base?
Conversation
I tried to create tests as well for whether the face pile on the poll options is hidden when the room has more than five members, but I found it very hard to do without relying much on implementation detail. |
I'm also open for other approaches to opening the detailed result list. One idea might be to make a separate, underlined span that just says "Open full results" next to it. |
Strict mode commit was temporarily reverted because of #28306 |
Also found the time to add an end to end test for the vote results dialog. If there is anything else that I can do to progress this PR further, please let me know. |
I see this has been sent to design & product for review, but I'm not really sure what this PR is trying to do. A description, linked bug and screenshot would help. That said, I suspect the answer from product will be that polls need to stay consistent between clients, so if this makes web display more than Element X, we'd also need to make corresponding changes there and land them around the same time. |
Oh sure. Damn I wanted to do that but forgot it again. Will do.
Okay. I will take a look if I can manage to do that. |
Checklist
New or updatednot applicablepublic
/exported
symbols have accurate TSDoc documentation.Closes #28488