Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use the sender when rendering the room creation event. #7640

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 9, 2023

On Room v11 it is possible that the sender could put in a fake creator. Don't allow this to happen.

The changelog already exists for this as #7633

On Room v11 it is possible that the sender could put in a fake creator. Don't allow this to happen.
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pixlwave pixlwave requested review from a team and Velin92 and removed request for a team August 9, 2023 10:13
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.14% 🎉

Comparison is base (d3e64c1) 12.21% compared to head (a68c6f0) 12.36%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7640      +/-   ##
===========================================
+ Coverage    12.21%   12.36%   +0.14%     
===========================================
  Files         1648     1648              
  Lines       163668   163660       -8     
  Branches     67195    67206      +11     
===========================================
+ Hits         19996    20236     +240     
+ Misses      143027   142759     -268     
- Partials       645      665      +20     
Flag Coverage Δ
uitests 55.05% <ø> (ø)
unittests 6.21% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m 16.97% <0.00%> (+0.04%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit f3b857f into develop Aug 9, 2023
13 checks passed
@pixlwave pixlwave deleted the doug/remove-room-creator branch August 9, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants