Add build setting to hide feedback

[langleyd]

Resolves #7102

[gileluard]

The "feedback" feature can be launched from the settings screen (e.g. Report bug cell). Shouldn't we hide this cell as well in this case?

[langleyd]

Actually there is already a build setting for that @gileluard . BuildSettings.settingsScreenAllowBugReportingManually

[gileluard]

Good point @langleyd . Your PR looks good to me but shouldn't we keep just one property in build settings in this case? I don't see why we'd need to build a client with the feedback button hidden and bug report available or the other way around.

[gileluard]

lgtm. See my only comment above.

[codecov]

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 11.73%. Comparing base (daa48a8) to head (3c901b8).
Report is 1850 commits behind head on develop.

Files with missing lines	Patch %	Lines
Riot/Modules/SideMenu/SideMenuViewModel.swift	0.00%	5 Missing ⚠️
...ot/Modules/Home/AllChats/AllChatsCoordinator.swift	60.00%	2 Missing ⚠️
Riot/Modules/Settings/SettingsViewController.m	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7104      +/-   ##
===========================================
- Coverage    11.74%   11.73%   -0.01%     
===========================================
  Files         1620     1620              
  Lines       159179   159219      +40     
  Branches     64743    64774      +31     
===========================================
+ Hits         18688    18692       +4     
- Misses      139855   139894      +39     
+ Partials       636      633       -3     

Flag	Coverage Δ
uitests	54.89% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[langleyd]

I can see why somebody might want report a bug in settings but not solicit general feedback. But in the case I am solving for hiding both is what I am doing, so happy to start with 1 BuildSetting. 👍

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[CLAassistant]

All committers have signed the CLA.