Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API support for reactions v1 #2392

Closed
12 of 20 tasks
manuroe opened this issue Apr 29, 2019 · 0 comments
Closed
12 of 20 tasks

API support for reactions v1 #2392

manuroe opened this issue Apr 29, 2019 · 0 comments

Comments

@manuroe
Copy link
Member

manuroe commented Apr 29, 2019

From riot-web created by jryans: element-hq/element-web#9485

We'll need API support for aggregations (to support message editing and reactions). This will likely be broken down into sub-tasks in React and JS SDKs once the shape of the API is known in more detail.

For the moment, matrix-org/matrix-spec-proposals#1849 gives some idea of the direction here.

  • parses and stores aggregated data
  • parses relates_to events
  • sends reactions
  • provides reactions based on event.unsigned.relations.annotations (data got after an initial /sync)
  • provide updated reactions
    • dedicated store for aggregated reactions
    • have a mechanism to notify updated reactions
    • store aggregated reactions only for events in the timeline we have (other may be not accurate)
    • keep event id of reactions made by the user (for unreaction and for displaying them differently in the UI)
    • keep it even if the event is not (or no more) in our the timelines
  • unreact
  • handle incoming unreaction

Moved to specific issues:

Performance: ->

@manuroe manuroe added this to the Sprint 20 milestone Apr 29, 2019
@manuroe manuroe self-assigned this May 10, 2019
@manuroe manuroe changed the title API support for aggregations API support for reactions May 21, 2019
@manuroe manuroe changed the title API support for reactions API support for reactions v1 May 21, 2019
@manuroe manuroe closed this as completed May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant