-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ia32 Windows target #1685
Drop ia32 Windows target #1685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to communicate this to existing users. Either by creating a message in the affected users app or via deprecating publicly and setting a death date or both.
I think we could add a toast (or banner?) for users on ia32 that tells them that they will be unsupported by X date. I do think the affected user pool will be very low, but I suppose in the range of 0.01~0.1% of users. Actually thinking a bit more abstract here, can we just have a toast for unsupported operating systems. I can imagine that this is relatively common for MacOS / Linux as we deprecated every so often? |
@t3chguy Can the toast we have for unsupported browsers be easily built upon for unsupported OSes? |
Perhaps but then you'd risk impacting a community maintained package for ia32, this would need to be a warning only for users of our own package surely |
@Half-Shot Is updating adding the upsupported OS toast(similar to the unupported browser one) something you would be able to take a look at as a part of this? |
Pragmatically, I don't think I've got enough time on my hands to work on that. I do think it would be useful for now and in the future, but presently I'm overbooked. |
Marking as draft until it is iterated upon so it doesn't keep coming back up in our weekly calls |
Rather than add to the backlog of draft PRs, I'm going to close this for now. We'd love to see this work done, but it seems nobody has time to bring it to completion. If anybody (@Half-Shot or otherwise) can take it on, we'd be delighted to reopen the PR! |
Fixes #1666
Discussed with product team beforehand as something we should just do at this point.
Checklist
public
/exported
symbols have accurate TSDoc documentation.