Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve typings and test mocks #315

Merged
merged 2 commits into from
Oct 8, 2024
Merged

chore: improve typings and test mocks #315

merged 2 commits into from
Oct 8, 2024

Conversation

dsanders11
Copy link
Member

Just some cleanup of the typings in this codebase.

  • Use jest.mocked for better typing
  • mockReturnValue(Promise.resolve(...)) -> mockResolvedValue(...)
  • Improve typing and remove most as any and : any types

@dsanders11 dsanders11 marked this pull request as ready for review October 7, 2024 21:26
@dsanders11 dsanders11 requested a review from a team as a code owner October 7, 2024 21:26
@dsanders11 dsanders11 merged commit 8c2c7ba into main Oct 8, 2024
3 checks passed
@dsanders11 dsanders11 deleted the chore/improve-typings branch October 8, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsanders11 @ckerr