Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add team_reviewers to requestReviewers #276

Merged

Conversation

alicelovescake
Copy link
Contributor

This PR:

  • Adds DEFAULT_BACKPORT_REVIEW_TEAM to missing team_reviewers param in octokit: See API doc
  • Should fix bug on why releases team is being tagged for automatic or manual backports

@alicelovescake alicelovescake requested a review from a team as a code owner April 5, 2024 23:52
src/utils.ts Outdated Show resolved Hide resolved
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing some search on GitHub to confirm, I think this does need to ensure that only the team slug, (e.g. wg-releases, not electron/wg-releases) gets used. Examples I found:

It would be nice to handle both cases since then we don't have to bug anyone about changing it if the current format is the prefixed version.

@alicelovescake
Copy link
Contributor Author

Doing some search on GitHub to confirm, I think this does need to ensure that only the team slug, (e.g. wg-releases, not electron/wg-releases) gets used. Examples I found:

It would be nice to handle both cases since then we don't have to bug anyone about changing it if the current format is the prefixed version.

Nice call! New changes should handle both the case that we have electron/wg-releases or if in the future we change it to just wg-releases.
const slug = DEFAULT_BACKPORT_REVIEW_TEAM.split('/')[1]; teamReviewers.push(slug ? slug : DEFAULT_BACKPORT_REVIEW_TEAM);

src/utils.ts Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the fix-manual-backport-reviewer branch from 8ddf495 to 9e4abd7 Compare April 8, 2024 14:18
@dsanders11 dsanders11 merged commit af2c668 into electron:main Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants