tidy(web): remove historical linking ff #7702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonypls
force-pushed
the
tvs/remove-historical-ff
branch
from
c875228 to
0a29884
Compare
VIKTORVAV99
requested changes
Jan 8, 2025
There was a problem hiding this comment.
All the non english translations still uses "hourly", "daily", "monthly", and "yearly" for the time range toggle.
We should probably adjust this to match the historical linking translations of 72h, 30d, 12m and all. For all languages or just delete the translations so they fall back to english so we keep it consistent. (Had a talk with Oli today about this, and we will change how this is selected going forward (unknown how yet) but we want to use 72h, etc in the meantime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Duplicate code paths make new dev slower
Description
This PR removes the FF for historical linking