fix(parsers, CO): adopt use_proxy, fix parsing, add tests #7690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parser
python
consideRatio
force-pushed
the
pr/fix-co
branch
from
45cb72f to
a0d7277
Compare
|
@VIKTORVAV99 I got this parser functional with this PR, but it builds on #7686 currently so I've made it draft until that PR resolves one way or another. |
consideRatio
force-pushed
the
pr/fix-co
branch
from
a0d7277 to
93c52b6
Compare
Changes: - Makes calling `fetch_production()` without args or kwargs not run into issues stemming from `zone_key` being explicitly passed as None. - Adds a comment on what webshare.io subscription is useful for use by this project. - Re-configures session.proxies back to what it was in a way that I think now will work, while previously I think we just stored a reference to the proxies object that we then also modified. This likely won't impact anyone. - Adjusted the code for readability, which is an opinionated matter of course.
consideRatio
force-pushed
the
pr/fix-co
branch
from
1513212 to
c5f8eb7
Compare
|
Learned more about pandas doing this work! It now works and tests are added to help future maintenance of this parser. |
consideRatio
changed the title
VIKTORVAV99
reviewed
Jan 8, 2025
Comment on lines
+59
to
+61
| @use_proxy(country_code="CO", monkeypatch_for_pydataxm=True) | ||
| def fetch_consumption( | ||
| zone_key: ZoneKey, | ||
| zone_key: ZoneKey = ZoneKey("CO"), |
There was a problem hiding this comment.
While I think this makes sense I need to double check a few things internally before we can merge this, specifically how much bandwidth/data we have available first as they don't yet support pay as you go billing or if we need to increase this so not all parsers that use the proxy goes down.
Hopefully I can get this done tomorrow or on Friday otherwise it will be early next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently based on top of #7686
This PR includes #7686, as it builds further on changes to the
use_proxydecorator.Issue
Description
CO proxy needed and added with monkeypatching
The CO parser now needs to be proxied from CO. However, since the CO parser makes use of the library pydataxm to make requests, and it can't be configured to use a proxy, I've monkeypatched
aiohttp.ClientSession.__init__andrequests.posttemporarily so that when they are used by pydataxm, it will proxy traffic anyhow.An upstream issue about this is EquipoAnaliticaXM/API_XM#37.
Live consumption parser fix
There was a datetime string returned sub-seconds, so I removed them before parsing the datetime.fromisoformat which in Python <= 3.10 doesn't handle that.
Historical parsers fixes
While
pydataxm.ReadDB().reques_data()has a function signature with start_date and end_date, it turns out that sometimes they aren't respected and more data for additional dates are returned. This seems to happen when requesting data from not very recent dates.I've updated the parser to handle receiving multiple dates for consumption/production/price parser, which all had the issue, but where the production parser didn't error but instead generated incorrect data I think.
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.