perf: Remove useEffect in GraphHoverLine.tsx and lift logic #7604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- web/src/features/charts/graphUtils.ts: Evaluated as low risk
- web/src/features/charts/tooltips/AreaGraphTooltip.tsx: Evaluated as low risk
- web/src/features/charts/CarbonChart.tsx: Evaluated as low risk
- web/src/features/charts/EmissionChart.tsx: Evaluated as low risk
- web/src/features/charts/OriginChart.tsx: Evaluated as low risk
| markerShowVerticalLine && | ||
| Number.isFinite(markerY) && | ||
| id === hoveredChart && | ||
| Number.isFinite(hoveredLayerIndex); |
There was a problem hiding this comment.
The condition Number.isFinite(hoveredLayerIndex) is not valid for checking the layer index. It should be hoveredLayerIndex !== null.
Suggested change
| Number.isFinite(hoveredLayerIndex); | |
| hoveredLayerIndex !== null; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
I don't know why they insist on this when Number.isFinite return false for everything that is not a float or int (an actual number).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We had a any type and used useEffect hooks.
Description
What started as a quick type fix quickly spiraled into a whole refractor of this part of the code. This enabled me to keep all the existing functionality, make it typesafe, remove the useEffect hook (making it more stable) and simplify the logic a bit.
Overall it's also a tiny bit smaller.
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.