bug(web): present electric net exchange chart for 30d+ views

[consideRatio]

Issue

Fixes #7593 - the issue includes an analysis and details on why this is reasonable to consider a bug fix.

Description

The net exchange chart wasn't presented for the 30d, 12mo, and all views.

Preview

Double check

• I have tested my parser changes locally with poetry run test_parser "zone_key"
• I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

[VIKTORVAV99]

Thanks for the PR @consideRatio!

Just a heads up that we just entered a code freeze so even if this is merged we won't be deploying new code until January.

@tonypls do you remember why we did this in the first place?

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

web/src/utils/helpers.ts:198

• The removal of the check for an empty 'exchange' object may lead to unintended behavior. Consider re-adding this check or ensuring that 'exchange' is never empty before calling this function.

if (Object.keys(zoneData.exchange).length === 0) {

[consideRatio]

@VIKTORVAV99 thank you for the quick response! I've updated the title of this PR and the linked issue to be about the electric net exchange chart, because the emission net exchange chart is still not showing up for another reason - now tracked by #7596.

[tonypls]

Thanks for the PR @consideRatio!

Just a heads up that we just entered a code freeze so even if this is merged we won't be deploying new code until January.

@tonypls do you remember why we did this in the first place?

Mostly to reduce the chance our Christmas celebrations are effected by production incidents.

This will be deployed to staging.electricitymaps.com once merged! 🚀

[VIKTORVAV99]

Thanks for the PR @consideRatio!

Just a heads up that we just entered a code freeze so even if this is merged we won't be deploying new code until January.

@tonypls do you remember why we did this in the first place?

Mostly to reduce the chance our Christmas celebrations are effected by production incidents.

This will be deployed to staging.electricitymaps.com once merged! 🚀

Not the code freeze 😅

Why we added the check that blocks the net exchange graph from the daily, monthly and yearly views?

[tonypls]

Thanks for the PR @consideRatio!

Just a heads up that we just entered a code freeze so even if this is merged we won't be deploying new code until January.

@tonypls do you remember why we did this in the first place?

Mostly to reduce the chance our Christmas celebrations are effected by production incidents.
This will be deployed to staging.electricitymaps.com once merged! 🚀

Not the code freeze 😅

Why we added the check that blocks the net exchange graph from the daily, monthly and yearly views?

Ah 😅 . I think because we don't show aggregate exchanges it didn't feel like the ideal solution but I guess because it's a net exchange it should be fine!

[VIKTORVAV99]

Tested locally and it works as expected so LGTM! 🎉

Thanks for opening the PR!

[consideRatio]

Thanks for the review efforts @VIKTORVAV99 and @tonypls, excited that a small fix like this enabled me to use the aggregated net exchange view which i find very interesting!

I want politicians to value low-carbon electricity exports, and not reason "but we'll manage with one less nuclear power plant or wind park" and instead value the climate impact abroad.

A view like this can help towards such insights i think!

[VIKTORVAV99]

Thanks for the review efforts @VIKTORVAV99 and @tonypls, excited that a small fix like this enabled me to use the aggregated net exchange view which i find very interesting!

I want politicians to value low-carbon electricity exports, and not reason "but we'll manage with one less nuclear power plant or wind park" and instead value the climate impact abroad.

A view like this can help towards such insights i think!

No problem at all and thanks for opening the PR!

I will look into the emissions part as well (in your other issue) in the when the code freeze is over in early Jan!

Thanks again!