Add blob support to _assertDeepEqual
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also, what it `type`?
- Switch back to the use of `type()` in the first `switch` to reduce impact on existing code - `type(blob())` returns "meta", so added code to specifically catch "meta", and then perform `typeof`. If the result of `typeof` is "blob", then we handle the same as the case of "table"/"class"/"array", but otherwise we handle it as the default case
|
It is recommended to compare blobs by the one imp API method - crypto.equals() that would make the code much simpler. Or do you need to print out the details of the comparison, like the "index" of the first non-equal byte, etc? |
|
I don't think printing out the first non-equal byte is necessary, so yes this could be updated to use |
|
Updated to use |
|
If you manually tested it, it's ready. |
|
:) will let you know soon |
|
oh... seems, it would be also good to add a check that value2 is a blob as well. |
|
I thought that was already in there, good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add blob support for PR #10