Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #16533 to 8.x: Health api minor followups #16534

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Backport PR #16533 to 8.x branch, original message:


Release notes

[rn:skip]

What does this PR do?

  • After delivering Feature: health report api #16520 Health API, CI didn't run with reason of either python or Java missed. This PR uses Ubuntu BK Agent and manually installs the pip module.
  • Fixes the flaky test sometimes failing after status reflected into node stats API.

Why is it important/What is the impact to the user?

No user impact.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

* Utilize default agent for Health API CI. Call python scripts from directly CI step.

* Change BK agent to support both Java and python. Install pip manually and send env vars to subprocess.

(cherry picked from commit 4037adf)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@mashhurs mashhurs merged commit ad7c614 into 8.x Oct 10, 2024
5 checks passed
@mashhurs mashhurs deleted the backport_16533_8.x branch October 10, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants