Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys for starting game #144

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Hotkeys for starting game #144

merged 6 commits into from
Jan 27, 2025

Conversation

vEnhance
Copy link
Contributor

@vEnhance vEnhance commented Nov 8, 2022

is this how you add a newline in JSX i have no idea lol

closes #136

is this how you add a newline in JSX i have no idea lol
@vEnhance vEnhance changed the title Closes #136 Hotkeys for starting game Nov 8, 2022
Copy link
Contributor

@HiddeKoerts HiddeKoerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the functionality a lot, and it works beautifully.

I'm personally not a fan of including the keyboard shortcut in the button label, it makes it visually very cluttered. I'd be in favor of removing it, and adding a paragraph on the 'Help' page (in the Layout and Controls section). Especially because the key combinations you have chosen (I don't know any better ones) might interact with browsers as well.

Also, would it be possible to have another hotkey for the 'Play again' button at the end of the game? That would be very helpful for someone to fully interact with the website by keyboard only.

@vEnhance
Copy link
Contributor Author

saw that development on this repo is starting back up again, so i'll try to bring this PR up to date at some point when i'm back in boston in january (so removing the keyboard shortcut and adding a "play again" hotkey).

@vEnhance
Copy link
Contributor Author

vEnhance commented Jan 5, 2025

Made the promised changes (although I'm not in boston yet: flying out today 😁 ).

@vEnhance
Copy link
Contributor Author

Just want to check if there's anything else needed for this or #145, no rush.
Have a nice weekend!

@ekzhang ekzhang merged commit 96277e0 into ekzhang:main Jan 27, 2025
4 checks passed
@ekzhang
Copy link
Owner

ekzhang commented Jan 27, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot keys to start a game
3 participants