Enable default addon creation for auto mode clusters #8140
Conversation
| autoDefaultAddonNames = append(autoDefaultAddonNames, addonName) | ||
| } else if addonInfo.IsDefaultAutoMode { | ||
| addons = append(addons, &api.Addon{Name: addonName}) | ||
| autoDefaultAddonNames = append(autoDefaultAddonNames, addonName) |
There was a problem hiding this comment.
hard to tell without the context of the PR (please update the PR body explaining the motivation behind the changes and intent), but when Auto Mode is enabled, I believe we do NOT want the add-ons deployed since they are provided automatically as part of Auto Mode. The only time we really want add-ons to be deployed is when there is a node group involved (either managed or self-managed)
There was a problem hiding this comment.
My apologies for not including description in the PR body, I had originally included one but it seemed to have not published. I have updated the description
There was a problem hiding this comment.
Yes you are correct, we do not want to install core networking addons on auto mode clusters, since these addons are provisioned as part of auto mode. This change does not enable installing vpc-cni, coredns, or kube-proxy, it only enables installing metrics-server by default.
Metrics-server was chosen to be installed by default based on default AWS EKS Console experience. Console will call EKS Addons create-addon api to provision metrics-server for the customer on cluster creation.
There was a problem hiding this comment.
Thank you @gustavodiaz7722 ! I left one tiny suggestion below
Co-authored-by: Amine <[email protected]>
|
This introduced a problem making it impossible to disable metrics-server in auto mode, see #8164 |
Description
This change enables the default addon creation workflow for auto mode clusters. Importantly though this change does not install networking addons by default. To start with only metrics-server addon will be installed by default. This will align EKSCTL experience with the default AWS EKS console experience, where by default auto mode clusters come with metrics-server enabled.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯