feat: add support for redis_family #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejhayes
changed the title
ejhayes
changed the title
|
Thanks for opening this PR @PandelisZ. Looks like the tests are hanging. Change looks good but I'll need to dig into this not working before I can bring this change in...hopefully should be resolved by mid week. |
|
Let me know if theres anything I can do to test it :) Is there CI ? or is it like just a npm run test ? We're running this on our production bull now and are very happy with it and its working smooooothly :) so thanks for your work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using upstash redis on fly which networks via IPV6.
Ioredis does not like this, so you have to pass a setting