Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix Astropy minversion for Lorentz1D result change #1107

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

olebole
Copy link
Contributor

@olebole olebole commented Sep 1, 2024

The patch was backported and is now in Astropy 6.3.1 6.1.3, which should be the minversion. That is a trivial fix to #1106 (comment).

@pllim
Copy link
Collaborator

pllim commented Sep 1, 2024

Hmm Python 3.10 job that pulled in astropy 6.1.3 failed.

The patch was backported and is now in Astropy 6.3.1,
which should be the minversion.
@olebole
Copy link
Contributor Author

olebole commented Sep 1, 2024

My fault. 6.1.3 vs. 6.3.1. Sorry. Corrected.

Copy link
Collaborator

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim pllim merged commit f3c995e into ejeschke:main Sep 1, 2024
10 checks passed
@ejeschke
Copy link
Owner

ejeschke commented Sep 1, 2024

Thank you, @olebole !

@olebole olebole deleted the astropy-6.3.1 branch November 13, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants