Add ability to plot tables in PlotViewer #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No hurry, @pllim. This is mostly copying a little code from a plugin you wrote to a viewer you wrote. We have a use case here. |
ejeschke
force-pushed
the
enhanced-plotviewer
branch
from
067bff9
to
961df3c
Compare
|
Rebased |
|
I probably won't have time till end of June. Is that too late? |
|
Yeah, probably. Don't worry about it. |
|
I might be able to review this next week if you still need help. Please let me know! |
No, I'm going to be adding to this, so don't worry about it for now. |
- modified Toolbar and Info plugins so that they can switch GUIs according
to the active viewer in a channel
- When viewing a table you can pick columns to plot in the Info bar
and make a plot that becomes its own Plotable object in the channel
- added methods to access viewers from channel object
- a few improvements to the plot viewer
ejeschke
force-pushed
the
enhanced-plotviewer
branch
from
34c244d
to
247886f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Plot viewer and integrates it more cleanly into a channel.
The main changes are that the
ToolbarandInfoplugins now adapt their GUI to the type of viewer that is showing in the channel. The table viewer now has controls to plot columns and this will create aPlotableobject that is inserted in the channel and can be viewed using the plot viewer.The Toolbar and Info bar GUIs for the plot viewer now have some controls for things that used to be embedded in the viewer itself--this makes more room for the plot.