Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to 1.21 #162

Closed
wants to merge 1 commit into from
Closed

Update Go to 1.21 #162

wants to merge 1 commit into from

Conversation

joaoeinride
Copy link

No description provided.

@joaoeinride joaoeinride requested a review from a team as a code owner November 10, 2023 08:16
Edholm
Edholm reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@Edholm Edholm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed? This forces everybody downstream to also upgrade which might be unnecessary unless we need the features of Go 1.21

Remember, this is an open-source repo so we don't really know the blast radius

@joaoeinride
Copy link
Author

I was on an upgrade spree. will close this since it isn't an application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edholm Edholm Edholm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaoeinride @Edholm