feat: Add P2P functionality #666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add P2P bootstrap and register behaviour to the polka-storage-provider-server.
4 tasks
th7nder
requested changes
Jan 7, 2025
aidan46
force-pushed
the
feat/peer-resolver
branch
from
13fb051 to
a3e3803
Compare
jmg-duarte
reviewed
Jan 9, 2025
aidan46
added
ready for review
th7nder
requested changes
Jan 10, 2025
| token: CancellationToken, | ||
| ) -> Result<(), P2PError> { | ||
| info!("Starting P2P bootstrap node"); | ||
| let tracker = TaskTracker::new(); |
There was a problem hiding this comment.
What's the reason for using tracker here? Can't we just spawn the task and await it in a select?
There was a problem hiding this comment.
The tracker is used to ensure a graceful shutdown by waiting for the p2p task to shutdown after the cancellation token has been invoked.
|
|
||
| /// Register the peer with the rendezvous point. | ||
| /// The ttl is how long the peer will remain registered in seconds. | ||
| async fn register( |
There was a problem hiding this comment.
I don't understand why we need to have two different swarms :( I'll need to read up on that.
There was a problem hiding this comment.
We need two swarms because each node behaves differently. Since we are not enforcing every storage provider to be a bootstrap node, we cannot require the bootstrap behaviour on a registration node. More information on swarm behaviour
aidan46
added
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds bootstrap and registration p2p node functionality to the polka-storage-provider-server. The node type is selected by passing the node-type argument into the CLI (bootstrap or registration). Configuration is read from a TOML file, see the example in the p2p-example-config folder. The P2P network supports an ED25519 private key in PEM file format.
The
generate-peer-idcommand has been added to the polka-storage-provider-client. This command generates a peer ID from an ED25519 public key PEM file and writes it to a file or stdout, depending on the--fileargument.Note:
I have not added any P2P discovery, this will be implemented in the fetching application. I can add a discovery example if needed.