test: deploy account on katana via beerus, scarb and starkli #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 6, 2024
sergey-melnychuk
approved these changes
Nov 6, 2024
tests/starknet/starkli.rs
Outdated
| ) -> Self { | ||
| let prefunded_account = match prefunded_account { | ||
| PreFundedAccount::Katana => "katana-0".to_string(), | ||
| PreFundedAccount::Sepolia => "TODO".to_string(), |
There was a problem hiding this comment.
If this TODO is not being addressed in this PR: let's maybe fail fast here, e.g. with unimplemented!().
tests/starknet/utils.rs
Outdated
| @@ -7,15 +7,15 @@ const SOURCE_LIB: &str = "./tests/starknet/contract/account/src/lib.cairo"; | |||
| const SOURCE_SCARB: &str = "./tests/starknet/contract/account/Scarb.toml"; | |||
|
|
|||
| #[allow(dead_code)] | |||
| pub fn prepare_account() -> Result<String, Error> { | |||
| pub fn prepare_account() -> Result<(String, String, String), Error> { | |||
There was a problem hiding this comment.
Nitpick: extract struct for the return type or at add a comment about what is being returned, it doesn't seem obvious which string represents what.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
starklilibrary is introduced in test environment. Additionally, a test case has been created, that uses all of the major tools fromstarknetecosystem:scarbstarklikatanabeerusIn the test case, a template account contract is compiled with
scarb, manipulated withstarkliand deployed viabeerustokatana. Necessary updates were done on the template contract because of the deployment issue.