-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to 0.7.1 rpc spec #753
Conversation
Preparations: sergey-melnychuk/iamgroot#3 |
f7f3cb7
to
ea613d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried it out with declaring V3 accounts on Katana with starkli and the newly added skip flag. It worked. Because of the failing tests, things that need to be updated:
- tests/rpc.rs
test_specVersion
is failing - I guess that it still calls 0.6 rpc api because it returns 0.6.0. Changing it to {https.//starknet-mainnet}.../rpc/v0_7/{API_KEY} in the secrets part of the enviroment should do it - When first bullet is fixed, I get in tests/exe.rs failing
test_call_regular_contract_class
. I guess that due to rpc changes, this also needs to be adapted - Not essential, but I think that it would be nice to also update README.md and state that we have migrated to rpc 0.7.1
Thank you for pointing out the explicit failed check :)
The
👍🏻 |
It is a bit hacky with this change of 0.6 to 0_7 in the .yml file. Proper way would be to change that env variable, but I understand that you have no access to secrets part. Until tomorrow, if no one responses your request about the secrets access in the repo or if it will be a bit problematic to change that, then I will approve it. |
003e9d8
to
4368247
Compare
Now the only secret is the Alchemy API KEY, not the full URL. This makes way more sense I think and allows us to easily swap versions/networks/etc in the URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0.7.0: https://github.com/starkware-libs/starknet-specs/tree/v0.7.0
0.7.1: starkware-libs/starknet-specs@v0.7.0...v0.7.1