Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to 0.7.1 rpc spec #753

Merged
merged 5 commits into from
Aug 29, 2024
Merged

feat: upgrade to 0.7.1 rpc spec #753

merged 5 commits into from
Aug 29, 2024

Conversation

sergey-melnychuk
Copy link
Collaborator

@sergey-melnychuk sergey-melnychuk commented Aug 27, 2024

@sergey-melnychuk
Copy link
Collaborator Author

Preparations: sergey-melnychuk/iamgroot#3

@sergey-melnychuk sergey-melnychuk changed the title feat: upgrade to 0.7.0 rpc spec feat: upgrade to 0.7.1 rpc spec Aug 27, 2024
Copy link
Contributor

@ICavlek ICavlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried it out with declaring V3 accounts on Katana with starkli and the newly added skip flag. It worked. Because of the failing tests, things that need to be updated:

  • tests/rpc.rs test_specVersion is failing - I guess that it still calls 0.6 rpc api because it returns 0.6.0. Changing it to {https.//starknet-mainnet}.../rpc/v0_7/{API_KEY} in the secrets part of the enviroment should do it
  • When first bullet is fixed, I get in tests/exe.rs failing test_call_regular_contract_class. I guess that due to rpc changes, this also needs to be adapted
  • Not essential, but I think that it would be nice to also update README.md and state that we have migrated to rpc 0.7.1

@sergey-melnychuk
Copy link
Collaborator Author

sergey-melnychuk commented Aug 28, 2024

tests/rpc.rs test_specVersion is failing - I guess that it still calls 0.6 rpc api because it returns 0.6.0. Changing it to {https.//starknet-mainnet}.../rpc/v0_7/{API_KEY} in the secrets part of the enviroment should do it

Thank you for pointing out the explicit failed check :)

When first bullet is fixed, I get in tests/exe.rs failing test_call_regular_contract_class. I guess that due to rpc changes, this also needs to be adapted

The test_call_regular_contract_class seems to pass against 0.7.1 endpoint just fine. Doesn't seem like anything needs to be fixed.

Not essential, but I think that it would be nice to also update README.md and state that we have migrated to rpc 0.7.1

👍🏻

@ICavlek
Copy link
Contributor

ICavlek commented Aug 28, 2024

It is a bit hacky with this change of 0.6 to 0_7 in the .yml file. Proper way would be to change that env variable, but I understand that you have no access to secrets part. Until tomorrow, if no one responses your request about the secrets access in the repo or if it will be a bit problematic to change that, then I will approve it.

@sergey-melnychuk
Copy link
Collaborator Author

sergey-melnychuk commented Aug 28, 2024

Now the only secret is the Alchemy API KEY, not the full URL. This makes way more sense I think and allows us to easily swap versions/networks/etc in the URL.

Copy link
Contributor

@ICavlek ICavlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergey-melnychuk sergey-melnychuk merged commit 331d5ef into main Aug 29, 2024
7 checks passed
@sergey-melnychuk sergey-melnychuk deleted the spec/0.7.0 branch August 29, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants