Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: included option to connect to Katana #733

Merged
merged 10 commits into from
Aug 28, 2024
Merged

Conversation

ICavlek
Copy link
Contributor

@ICavlek ICavlek commented Jul 31, 2024

Beerus can now connect to Katana local node which makes development easier (no need to ping live starknet network). It is only necessary to set starknet_rpc inside the configuration file to url on which Katana is started (e.g. "http://127.0.0.1:5050").

@ICavlek ICavlek requested a review from a team July 31, 2024 13:39
@ICavlek ICavlek linked an issue Jul 31, 2024 that may be closed by this pull request
src/config.rs Outdated Show resolved Hide resolved
@ICavlek ICavlek force-pushed the ic/connect_with_katana branch 2 times, most recently from 0d140d6 to c5a91ae Compare August 7, 2024 06:43
src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
@ICavlek
Copy link
Contributor Author

ICavlek commented Aug 8, 2024

@sergey-melnychuk I have removed skip_chain_id_validation from configuration file. I have also replied on some of your comments regarding changes

src/config.rs Outdated Show resolved Hide resolved
src/bin/beerus.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
@ICavlek
Copy link
Contributor Author

ICavlek commented Aug 27, 2024

@sergey-melnychuk I have removed unnecessary Result<> and migrated check of config file to get_config function. There, if a skip_chain_id_validation flag is set, it provides a warning and doesn't call validate_chain_id function.

@ICavlek ICavlek merged commit 7210a6b into main Aug 28, 2024
7 checks passed
@ICavlek ICavlek deleted the ic/connect_with_katana branch August 28, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: connect beerus with Katana
2 participants