-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: included option to connect to Katana #733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-melnychuk
requested changes
Aug 6, 2024
ICavlek
force-pushed
the
ic/connect_with_katana
branch
from
August 6, 2024 12:56
98da414
to
463fba2
Compare
ICavlek
force-pushed
the
ic/connect_with_katana
branch
2 times, most recently
from
August 7, 2024 06:43
0d140d6
to
c5a91ae
Compare
sergey-melnychuk
requested changes
Aug 8, 2024
@sergey-melnychuk I have removed skip_chain_id_validation from configuration file. I have also replied on some of your comments regarding changes |
sergey-melnychuk
requested changes
Aug 19, 2024
ICavlek
force-pushed
the
ic/connect_with_katana
branch
from
August 26, 2024 16:31
7611957
to
1214177
Compare
ICavlek
force-pushed
the
ic/connect_with_katana
branch
from
August 27, 2024 07:39
1214177
to
28a04bd
Compare
@sergey-melnychuk I have removed unnecessary |
sergey-melnychuk
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beerus can now connect to Katana local node which makes development easier (no need to ping live starknet network). It is only necessary to set starknet_rpc inside the configuration file to url on which Katana is started (e.g. "http://127.0.0.1:5050").