Add a new API for listing logs and artifacts from a log area #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
t-persson
force-pushed
the
logarea-list-api
branch
from
e075bec
to
eda7427
Compare
|
This change works if the changes in #65 are merged. All CI problems are for python code and I have not changed any python code |
In certain cases services may store files in different parts of the log area. We will now require the download part to be an array of download areas.
fredjn
requested changes
Jun 14, 2024
Spelling errors Added panicRecovery and timeout Removed unused context Added nosniff header
fredjn
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
eiffel-community/etos#238
Description of the Change
Added a v1alpha API for listing logs and artifacts produced by ETOS. This is to be used to reduce the load of the event repositories when ETOS executes many testruns.
Alternate Designs
I thought about proxying the files directly from the API and have the client always know how to download the files. I decided against it due to the added complexity and not wanting to deal with memory usage in the logarea service. This is something that may be looked at in a v1 release of the API.
Possible Drawbacks
This API service will get a lot of traffic instead of the event repository. However I do believe that this solution is more scalable than the Eiffel GraphQL API.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]