Register providers at etos-api launch #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andmat900
requested review from
t-persson and
fredjn
and removed request for
a team
andmat900
force-pushed
the
20240305_register_providers
branch
2 times, most recently
from
d6d2f12
to
2441c6d
Compare
andmat900
force-pushed
the
20240305_register_providers
branch
from
2441c6d
to
9118579
Compare
fredjn
reviewed
Mar 5, 2024
python/src/etos_api/__init__.py
Outdated
| @@ -56,3 +57,5 @@ | |||
| FastAPIInstrumentor().instrument_app( | |||
| APP, tracer_provider=PROVIDER, excluded_urls="selftest/.*,logs/.*" | |||
| ) | |||
|
|
|||
| REG = RegisterProviders() | |||
There was a problem hiding this comment.
The initial idea was to place it in main.py. However this file seems to be the actual entry point that imports from main.py.
Should this be moved to main.py or some other place?
|
Perhaps we should mention in the PR description that this is a move of functionality from the Environment Provider, and somehow reference the bigger change(s) to transform the Environment Provider form Service -> Library. |
The PR description is now updated. |
fredjn
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Description of the Change
This change implements the registration of providers when etos-api is launched.
The code is taken from etos-environment-provider. This is part of the bigger change of transforming the Environment Provider from a service to a library.
Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Andrei Matveyeu, [email protected]