Abort running suites using DELETE request #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andmat900
requested review from
t-persson and
fredjn
and removed request for
a team
andmat900
force-pushed
the
20240220_abort_feature
branch
7 times, most recently
from
01dfc74
to
157d299
Compare
fredjn
requested changes
Feb 22, 2024
andmat900
force-pushed
the
20240220_abort_feature
branch
4 times, most recently
from
ed41c2f
to
573b9d3
Compare
andmat900
force-pushed
the
20240220_abort_feature
branch
from
573b9d3
to
070a73f
Compare
* Remove the environment provider router We'll now just let the ETOS API save the providers in the database instead of sending HTTP requests to the environment provider.
…i into 20240220_abort_feature
fredjn
approved these changes
Mar 6, 2024
|
Closing this PR to conflicts/rebase errors. Created a new one: #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Description of the Change
The change implements the handling of DELETE requests at the endpoint:
/etos/<suite_id>
Upon receiving a request to this endpoint, ETOS API deletes the correspoding Kubernetes job. If no job is found for the given suite id, a 404 response is returned.
Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Andrei Matveyeu, [email protected]