Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lfhcal geoupdate #798

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Lfhcal geoupdate #798

merged 7 commits into from
Oct 22, 2024

Conversation

FriederikeBock
Copy link
Contributor

@FriederikeBock FriederikeBock commented Oct 14, 2024

Briefly, what does this PR introduce?

implements latest geometry of the lfhcal

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@veprbl veprbl added this to the 24.11.0 milestone Oct 15, 2024
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add debug comments (feel free to keep them locally!)

src/LFHCAL_geo.cpp Outdated Show resolved Hide resolved
src/LFHCAL_geo.cpp Outdated Show resolved Hide resolved
compact/hcal/lfhcal.xml Outdated Show resolved Hide resolved
@veprbl veprbl enabled auto-merge October 19, 2024 13:32
@veprbl veprbl added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 22, 2024
@veprbl veprbl added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@veprbl veprbl added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit c01922f Oct 22, 2024
115 checks passed
@veprbl veprbl deleted the lfhcal_geoupdate branch October 22, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants