[aranya_lumidesign] LumiCal Material/Dim updates. #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update thickness of "coating"/box layers
Switch material for box to polystyrene from aluminium. Switch fiber holder material from brass to steel.
Changed thickness of fiber holder (alignment meshes) to 0.4mm from 0.6mm.
for more information, see https://pre-commit.ci
veprbl
approved these changes
Oct 14, 2024
|
|
||
| //Fiber Holder | ||
| auto fiberholder_x = mod_x.child(_Unicode(fiberholder)); | ||
| double fh_dz = 0.6 *mm; //thickness of fiber holder | ||
| double fh_dz = 0.4 * mm; //thickness of fiber holder |
|
(weren't targeting main branch) |
veprbl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Updated the fiber holder material (brass -> steel) and dimensions (0.6mm thick -> 0.4mm thick) to reflect latest physical versions.
Updated the box material (aluminium - > plastic) and dimensions (y thickness 0.5cm -> 0.25cm).
What kind of change does this PR introduce?
Please check if this PR fulfills the following: