Modified Barrel TOF geometry to add dead spaces between sensors and between support ring structure #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kerWithFrame_geo.cpp, but it is modified to accommodate multile sensors with dead spaces.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Dmitry Kalinkin <[email protected]>
github-actions
bot
added
topic: barrel
6 tasks
|
The check run "eicweb/eic_container" has been pending for about a day now while everything else (except linux-eic-shell / validate-material-map) have passed. Does anyone know why is that job pending for so long? Are there things I can do to speed it up? Edit: NVM, I was just too impatient. The job eventually finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
The BTOF active volume is modified to be more realistic. Now there are dead spaces between each sensors on a stave and extra dead space is reserved in the center of the BTOF to make space for the central supporting ring structure.
Variables relevant to the dead spaces, sensor sizes and the width of the ring are adjustable from tof_barrel.xml.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?