[DONTMERGE] definitions.xml: set EcalEndcapP_rmax to 172 cm #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
force-pushed
the
EcalEndcapP_rmax_172
branch
from
1ed078a
to
b3599aa
Compare
|
Based on a recent ref, https://indico.bnl.gov/event/22766/, it seems like EcalEndcapP_rmax should stay at 195 cm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allegedly, the calorimeter in simulation is larger than in engineering. This number was picked during a meeting from Alexander Bazilevski (of the top of his head).
(172 doesn't divide by 2.5, also it is not supported by the current menagerie https://eic.jlab.org/Geometry/Detector/Detector-20240117135224.html where it's still 195)