Add hadron magnetic fields for nuclei #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nothing major to comment on. If we use he3, he4, can we use h2, pb, and au as well? And while we're at it can we use capitalization like Au, Pb, He, H? |
|
Sure. I'm taking a day off tomorrow so I'll fix it after the holiday
Monday, so Tuesday.
…On Thu, Aug 31, 2023, 8:09 PM Wouter Deconinck ***@***.***> wrote:
Nothing major to comment on. If we use he3, he4, can we use h2, pb, and au
as well? And while we're at it can we use capitalization like Au, Pb, He, H?
—
Reply to this email directly, view it on GitHub
<#508 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADABSF7BJHATKNVAPBZS7VDXYERSHANCNFSM6AAAAAA4GMZRIE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
In that case I can do it. Should make it easier as we want to tag on Tuesday. |
|
Okay, thank you.
…On Thu, Aug 31, 2023, 8:15 PM Wouter Deconinck ***@***.***> wrote:
In that case I can do it. Should make it easier as we want to tag on
Tuesday.
—
Reply to this email directly, view it on GitHub
<#508 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADABSF6R224P7F3AMNJ23SDXYESJJANCNFSM6AAAAAA4GMZRIE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
wdconinc
approved these changes
Sep 1, 2023
wdconinc
force-pushed
the
add-hadron-magnetic-fields-for-nuclei
branch
from
a013b9c
to
e3f024b
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Added a few extra magnetic field configurations to make user's life easier. There is a caveat for light-ions, however. We do not have real lattice files, so properly steering the beams for the far-forward detectors will mean that the B0 field is scaled down, which will worsen the resolution for B0 tracking + reco. You will still see hits, etc., but you will see pT and p resolution much worse than for a standard field file. Until we have new lattice files, users will need to run simulations twice if using both B0 + RP/OMD information for various events.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No, just adds a few more configuration files.
Does this PR change default behavior?
No.