Faster bottom up algorithm based on faster-greedy-dag #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrosent
approved these changes
Dec 9, 2023
| } | ||
| } | ||
|
|
||
| /** A data structure to maintain a queue of unique elements. |
There was a problem hiding this comment.
Why copy-paste this from the other file? Can we move it to a shared module?
There was a problem hiding this comment.
I'm against sharing code between these algorithms for now: I think it's good to be able to tweak them without worrying about changing the comparison.
src/extract/faster_bottom_up.rs
Outdated
| costs.insert(class_id.clone(), cost); | ||
| analysis_pending.extend(parents[class_id].iter().cloned()); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Why do we need this?
Right now, there's at least one child that doesn't currently have a cost. That means that at some point if we can extract this node at all we number of "unextracted children" will go from 1 to 0. At that point, this node would get re-added, no?
There was a problem hiding this comment.
Good point! That actually made it significantly faster!
It also made faster-greedy-dag faster
cumulative time for faster-bottom-up: 1155ms
cumulative time for faster-greedy-dag: 1834ms
ezrosent
approved these changes
Dec 13, 2023
oflatt
force-pushed
the
oflatt-faster-baseline
branch
from
84e2215
to
0b832c3
Compare
This was referenced Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TrevorHansen's optimization using parent pointers also makes the bottom up algorithm without sharing faster