Make graphviz colors consistent and fix color bug #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if you have two graphs which use the same types, the colors per type might be different, depending on which type comes first. This makes comparing similar graphs harder visually. This resolves that by using a sorted map for mapping types to values, so that if the same set of types are used by two graphs, they will have the same colors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the colors assigned to different types consistent across multiple e-graphs with the same types. Previously, they could differ, which would lead to harder to understand diffs.
It also fixes a bug where if there were more types than the max number of colors, it would assign an incorrect color ID.