Remove extra blocks for return statements #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oflatt
force-pushed
the
oflatt-remove-extra-block
branch
from
58d823e
to
59f285c
Compare
chandrakananandi
approved these changes
Oct 30, 2024
| .fuze_up() | ||
| .return_early() | ||
| .return_early() | ||
| .collapse_empty_blocks() |
There was a problem hiding this comment.
collapse_empty also needs to be run to fixpoint? We cant do it in a single pass?
There was a problem hiding this comment.
If there are two empty blocks, you need to skip both of them. This pass only does it once per time it runs
| } | ||
|
|
||
| /// Find cases where a block jumps directly to another block A -> B where B | ||
| /// Converts footers into bril expressions to simplify this pass | ||
| fn remove_footers(mut self) -> SimpleCfgFunction { |
There was a problem hiding this comment.
Footers are used by the RVSDG translation to track new stuff added to the block
We don't really care about footers vs instructions so we convert them here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small optimization that moves return statements up into parent blocks