Artist genres #57
Artist genres #57
Conversation
| import com.efedaniel.spotifystats.ui.proton.tokens.color.ProtonColor | ||
|
|
||
| @Composable | ||
| fun Chip(genre: String) { |
There was a problem hiding this comment.
Can i ask why we have a different composable & file for this? Thanks
There was a problem hiding this comment.
I noticed we have a file for other composable in the project so I followed the same pattern
There was a problem hiding this comment.
I see. Good observation.
Those are components in the design system i.e. Proton. So we have like ProtonText, ProtonButton, Proton Snackbar, etc.
It will be a good idea to have ProtonChip but that will mean it has to be generic. i.e.
- it will need to have
textas the parameter instead ofgenre - It will need to hoist the onClick parameter
- And it would need to either have a standardized color or have a parameter for color.
There was a problem hiding this comment.
True, I will adjust that and make the Proton chip generic so that it can be reusable
There was a problem hiding this comment.
I have a question, why is there "Proton" prefix before the real name of the composable
efguydan
added
the
HACKTOBERFEST-ACCEPTED
|
Btw you didnt create an issue for it so i did. #58 |
|
Thanks |
I added the chips to display the genres