-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artist genres #57
Artist genres #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contrubutions
import com.efedaniel.spotifystats.ui.proton.tokens.color.ProtonColor | ||
|
||
@Composable | ||
fun Chip(genre: String) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can i ask why we have a different composable & file for this? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed we have a file for other composable in the project so I followed the same pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Good observation.
Those are components in the design system i.e. Proton. So we have like ProtonText, ProtonButton, Proton Snackbar, etc.
It will be a good idea to have ProtonChip but that will mean it has to be generic. i.e.
- it will need to have
text
as the parameter instead ofgenre
- It will need to hoist the onClick parameter
- And it would need to either have a standardized color or have a parameter for color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I will adjust that and make the Proton chip generic so that it can be reusable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question, why is there "Proton" prefix before the real name of the composable
Btw you didnt create an issue for it so i did. #58 |
Thanks |
I added the chips to display the genres