Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #28 Add Windows Support #34

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

hancockks
Copy link

No description provided.

@hancockks hancockks changed the title Issue #18 Add Windows Support Issue #28 Add Windows Support Aug 5, 2016
@edwardcapriolo
Copy link
Owner

Great work here. IT would be super great to get this merged. I realize it is an if statement nightmare :)

@hancockks
Copy link
Author

Yeah, sorry I've been MIA. It's failing tests on Linux, so I need to get a linux dev system up so I can see what I broke...

I have noticed in practical use of this on Windows, that if you stop/terminate debugging of a unit test, the forked process never gets closed. I could do something crufty such as when the process starts up, check to see if there's an existing process with the same binary path and kill it off first. Suggestions?

@edwardcapriolo
Copy link
Owner

Hey no worries about the time. I only wanted to let you know that I will work to get anything merged with you. Possibly we need to find some qemu vbox setup to test.

As to your question:

{quote}
that if you stop/terminate debugging of a unit test, the forked process never gets closed
{quote}
I have noticed this too. I am not sure what that is. My thinking is the way to handle this might be to insert a magic string into the command line and a shutdown hook to kill the process off. But again you never know when/if the hook will fire. If you get an idea on this let me know.

@hancockks
Copy link
Author

Huh. Wouldn't you know it. I got a dev environment with CentOS 7.1 and ran the unit tests under Eclipse and they're all working. I'm trying to grock the travis-ci log...it appears that cassandra didn't terminate in one of the tests, but I'm not seeing it.

@edwardcapriolo
Copy link
Owner

The travis-ci is a bit flaky. If something weird try a second push being that random failures happen.

@edwardcapriolo
Copy link
Owner

Did you ever get this working? I landed ina windows env and even with cygwin I run into issues with /bin/bash not found

@hancockks
Copy link
Author

hancockks commented Apr 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants