Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicated event in Chinese, Japanese and Korean languages #62

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

astrocket
Copy link
Contributor

@astrocket astrocket commented Nov 29, 2023

Currently with CJK languages, keyboard event is duplicated on 'Enter' click.

This PR prevents CJK users from unexpected character duplication.

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/isComposing

fixes #16, #56

Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please, update a patch version in package.json

@astrocket
Copy link
Contributor Author

@neSpecc just bumped up minor version.

@neSpecc neSpecc merged commit 95b3746 into editor-js:main Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line breaking behaving weird for CJK language
2 participants