feat(OrderedList UI): support start property #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- start property saves with ordered list style
add change of the start propery on rendering of the list
neSpecc
reviewed
Oct 23, 2024
neSpecc
reviewed
Oct 23, 2024
src/utils/renderToolboxInput.ts
Outdated
Comment on lines
27
to
30
| /** | ||
| * Value of the start property, if it is not specified, then it is set to one | ||
| */ | ||
| value: start ?? 1, |
src/utils/renderToolboxInput.ts
Outdated
Comment on lines
36
to
37
| input.setAttribute('type', 'number'); | ||
| input.setAttribute('pattern', '\d*'); |
neSpecc
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Problem is discussed in this issue #66
Solution
Now we can set start property for OrderedList:
We use custom html inside of the toolbox to render input:
We check, that input value is actually integer:
OrderedList data model now contains extra field related to the whole list
Checklist and Unordered list does not save this field
Note that UI is still to be improved