Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(toolbox): export all lists into toolbox #88

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

e11sy
Copy link
Contributor

@e11sy e11sy commented Oct 14, 2024

Problem

Now only harcoded list style (ordered list) is exported to toolbox
It is not responsible to the config.defaultStyle as mentioned in #70

Solution

Export all available lists to the toolbar
image

Related problems

  • Now all lists displayed with the same shortcut
  • When i actually use shortcut, convertion config is triggered (static getter)
    I expect to convert current block to the NestedList with defaultStyle, and now paste config uses hardcoded unordered style

Note that related problems should be solved in Editor.js
After that hardcoded list style should be removed from convertionConfig

src/index.ts Show resolved Hide resolved
@e11sy e11sy merged commit 645d783 into release/2.0 Oct 14, 2024
1 check passed
@e11sy e11sy deleted the improve-toolbox branch October 14, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants