Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type issue fixed, closes #131 #132

Merged
merged 2 commits into from
Oct 12, 2024
Merged

type issue fixed, closes #131 #132

merged 2 commits into from
Oct 12, 2024

Conversation

Sozialarchiv
Copy link
Contributor

@Sozialarchiv Sozialarchiv commented Oct 12, 2024 •
edited by neSpecc
Loading

This commit fixes an issue with type import:

node_modules/.pnpm/@[email protected]/node_modules/@editorjs/embed/dist/index.d.ts:1:51 - error TS2307: Cannot find module './types/types' or its corresponding type declarations.

1 import { ServiceConfig, ServicesConfigType } from './types/types';

Types should not use here as a folder name.

Resolves #131

neSpecc
neSpecc reviewed Oct 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
neSpecc
neSpecc reviewed Oct 12, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@Sozialarchiv
Copy link
Contributor Author

I added all your suggestions.

@Sozialarchiv
Copy link
Contributor Author

Imho we can also close #101 with this pr.

@neSpecc neSpecc merged commit 801580f into editor-js:master Oct 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

types issue: Cannot find module './types/types'
2 participants
@Sozialarchiv @neSpecc