-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Save postgres superuser password in secretstore #5051
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #5051 +/- ##
==========================================
- Coverage 28.10% 28.04% -0.06%
==========================================
Files 256 256
Lines 18460 18515 +55
==========================================
+ Hits 5188 5193 +5
- Misses 12074 12124 +50
Partials 1198 1198 ☔ View full report in Codecov by Sentry. |
Resolves edgexfoundry#5050. Save postgres superuser password in secretstore. Signed-off-by: Lindsey Cheng <[email protected]>
Remove the password file in postgres entrypoint script lastly. Signed-off-by: Lindsey Cheng <[email protected]>
17721e1
to
77b7903
Compare
Quality Gate passedIssues Measures |
internal/security/bootstrapper/postgres/handlers/handlers.go
Dismissed
Show dismissed
Hide dismissed
@@ -21,7 +21,11 @@ import ( | |||
"github.com/edgexfoundry/go-mod-bootstrap/v4/di" | |||
) | |||
|
|||
const postgresSecretName = "postgres" | |||
const ( | |||
postgresSecretName = "postgres" // nolint:gosec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postgresSecretName = "postgres" // nolint:gosec | |
postgresSecretName = "postgres" |
Resolves #5050. Save postgres superuser password in secretstore.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)