deps: remove dependency on helm/v2 #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Weiße <[email protected]>
✅ Deploy Preview for constellation-docs canceled.
|
Coverage report
|
msanft
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We had a dependency on helm v2 through an incorrect import of
helm.sh/helm/pkg/ignoreinstead ofhelm.sh/helm/v3/pkg/ignore.As far as I can tell this had no real impact on our code, yet its a dependency we do not need, since we already import helm v3, which offers the same package.
Proposed change(s)
helm.sh/helm/pkg/ignorewithhelm.sh/helm/v3/pkg/ignoreto remove helm v2 from our dependenciesRelated issue
Checklist