Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove go.mod files from submodules #2769

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Dec 21, 2023

Context

We want to get rid of our multiple go.mod files in submodules and use just a single go.mod file for our project.

Proposed change(s)

  • Remove go.mod files

Additional info

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 50bd512
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/659bd248acf2ac00081c01e5

Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
@katexochen katexochen removed their request for review January 8, 2024 10:50
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Coverage report

Package Old New Trend
cli/internal/cmd 58.50% 58.50% ↔️
hack/gocoverage 59.20% 59.20% ↔️
internal/constellation/kubecmd 67.90% 67.90% ↔️
operators/constellation-node-operator 0.00% [no test files] 🚨
operators/constellation-node-operator/api 0.00% [no test files] 🚨
operators/constellation-node-operator/api/v1alpha1 0.00% [no test files] 🚨
operators/constellation-node-operator/controllers 0.00% 30.80% 🆕
operators/constellation-node-operator/internal/cloud/api 0.00% [no test files] 🚨
operators/constellation-node-operator/internal/cloud/aws/client 0.00% 78.40% 🆕
operators/constellation-node-operator/internal/cloud/azure/client 0.00% 88.90% 🆕
operators/constellation-node-operator/internal/cloud/fake/client 0.00% [no test files] 🚨
operators/constellation-node-operator/internal/cloud/gcp/client 0.00% 80.80% 🆕
operators/constellation-node-operator/internal/constants 0.00% [no test files] 🚨
operators/constellation-node-operator/internal/controlplane 0.00% 100.00% 🆕
operators/constellation-node-operator/internal/deploy 0.00% 76.60% 🆕
operators/constellation-node-operator/internal/etcd 0.00% 65.80% 🆕
operators/constellation-node-operator/internal/executor 0.00% 89.50% 🆕
operators/constellation-node-operator/internal/node 0.00% 100.00% 🆕
operators/constellation-node-operator/internal/patch 0.00% 100.00% 🆕
operators/constellation-node-operator/internal/poller 0.00% 91.40% 🆕
operators/constellation-node-operator/internal/upgrade 0.00% [no test files] 🚨
operators/constellation-node-operator/sgreconciler 0.00% 34.90% 🆕
terraform-provider-constellation [no test files] [no test files] 🚧

@elchead
Copy link
Contributor

elchead commented Jan 8, 2024

can you link a test run for the provider and a normal CLI cluster?

Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform E2E Test issue is unrelated to this PR, i think this should be good to merge.

Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this to unblock pending dependency upgrades. I built everything locally for testing purposes and it looks very promising!

@daniel-weisse daniel-weisse added the no changelog Change won't be listed in release changelog label Jan 8, 2024
@daniel-weisse daniel-weisse merged commit 90f3336 into main Jan 8, 2024
14 of 15 checks passed
@daniel-weisse daniel-weisse deleted the ref/go/mod-file branch January 8, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants