-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support internal load balancer setup on Azure #2608
Draft
3u13r
wants to merge
3
commits into
main
Choose a base branch
from
feat/cli/allow-internal-lb-on-azure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3u13r
force-pushed
the
feat/cli/allow-internal-lb-on-azure
branch
from
November 16, 2023 14:58
0a858cc
to
8798f58
Compare
derpsteb
reviewed
Nov 17, 2023
derpsteb
reviewed
Nov 17, 2023
Ah the strict node-to-node routing in combination with Azure internal LB's not doing SNAT breaks this feature for now. I can fix this in our Cilium fork though. We'll need another exception port (as we already do for both etcd ports). |
3u13r
force-pushed
the
feat/cli/allow-internal-lb-on-azure
branch
from
November 23, 2023 21:10
39860b4
to
1ff5ccc
Compare
We don't use konnectivity anymore. Therefore, we can enable internal using an internal load balancer on azure.
3u13r
force-pushed
the
feat/cli/allow-internal-lb-on-azure
branch
from
November 27, 2023 12:17
1ff5ccc
to
4c8f2b7
Compare
Coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Proposed change(s)
Additional info
Checklist