review changes

edgelesssys · Oct 29, 2024 · 4b62216 · 4b62216
1 parent 06dd8dd
commit 4b62216
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/internal/config/config_test.go b/internal/config/config_test.go
@@ -826,6 +826,23 @@ func TestValidInstanceTypeForProvider(t *testing.T) {
 			expectedResult: false,
 			providerConfig: ProviderConfig{OpenStack: &OpenStackConfig{Cloud: "stackit"}},
 		},
+		"openstack test": {
+			variant: variant.QEMUVTPM{},
+			instanceTypes: []string{
+				"foo.bar",
+				"foo.bar1",
+			},
+			expectedResult: true,
+			providerConfig: ProviderConfig{OpenStack: &OpenStackConfig{Cloud: "test"}},
+		},
+		"no provider config": {
+			variant: variant.QEMUVTPM{},
+			instanceTypes: []string{
+				"foo.bar",
+			},
+			expectedResult: true,
+			providerConfig: ProviderConfig{},
+		},
 	}
 	for name, tc := range testCases {
 		t.Run(name, func(t *testing.T) {

diff --git a/internal/config/validation.go b/internal/config/validation.go
@@ -550,13 +550,15 @@ func validInstanceTypeForProvider(insType string, attestation variant.Variant, p
 		}
 	case variant.QEMUVTPM{}, variant.QEMUTDX{}:
 		// only allow confidential instances on stackit cloud using QEMU vTPM
-		if cloud := provider.OpenStack.Cloud; strings.ToLower(cloud) == "stackit" {
-			for _, instanceType := range instancetypes.STACKITInstanceTypes {
-				if insType == instanceType {
-					return true
+		if provider.OpenStack != nil {
+			if cloud := provider.OpenStack.Cloud; strings.ToLower(cloud) == "stackit" {
+				for _, instanceType := range instancetypes.STACKITInstanceTypes {
+					if insType == instanceType {
+						return true
+					}
 				}
+				return false
 			}
-			return false
 		}
 
 		return true