Ensure Kubernetes compatible format for Location when setting up driver #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Weiße <[email protected]>
derpsteb
approved these changes
Sep 27, 2023
daniel-weisse
changed the title
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
fix/csp/zone-parsing
branch
from
817e7c1
to
0cff633
Compare
daniel-weisse
added a commit
that referenced
this pull request
Sep 29, 2023
…er (#45) Signed-off-by: Daniel Weiße <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where disks could not be deployed when nodes in the cluster were assigned to specific zones because the location set in the Cloud config read by the driver has ambiguous format (Upper case with spaces, or all lower case no spaces).
Using the upper case format results in errors when setting or comparing the location/zone to topology keys
We fix this by ensuring location is always lowercase with no spaces.