Hooks #1449
Hooks #1449
Conversation
aljazerzen
force-pushed
the
hooks
branch
2 times, most recently
from
d3deae9 to
bea254b
Compare
aljazerzen
force-pushed
the
project-manifest
branch
from
9cf7e12 to
767f6ef
Compare
(and also database.wipe.before & database.wipe.after)
|
I need an install of windows to implement hooks in WSL. |
| if let Some(project) = &context.get_project().await? { | ||
| hooks::on_action("branch.switch.before", project).await?; | ||
| } |
There was a problem hiding this comment.
Would it be cleaner to have hooks::on_action (or something similar) take a context and then call it unconditionally in each call site, and have the logic there?
There was a problem hiding this comment.
We have a few different contextes: branching, migration, project. Some are subsets of other and contain different amounts of information.
hooks::on_action takes project::Context
| pro.arg(pair); | ||
| } | ||
| // TODO: set current dir | ||
| pro.arg("/bin/sh"); |
There was a problem hiding this comment.
Make sure not to lose track of this
There was a problem hiding this comment.
Yes, this will be implemented when I do WSL for real.
| [instance] | ||
| server-version = "nightly" | ||
|
|
||
| [project] | ||
| schema-dir = "./database_schema" | ||
|
|
||
| [hooks] | ||
| project.init.before = "true" | ||
| project.init.after = "true" | ||
| branch.switch.before = "true" | ||
| branch.switch.after = "true" | ||
| branch.wipe.before = "true" | ||
| branch.wipe.after = "true" | ||
| migration.apply.before = "true" | ||
| migration.apply.after = "true" |
There was a problem hiding this comment.
Probably we want some tests where we can test they ran in the right context?
Do we want
beforehooks too? I've implemented some because they were easy.