-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local WLAN http-pages, influx-db integration and translation system #453
base: master
Are you sure you want to change the base?
Conversation
* a web page with actual sensor data, incl. wifi signal quality, firmware version... * a debug web page, showing the serial log, change of log level * adds a influx-db option in the configuration * fixes a bug in the configuration page : on first time call, text attributes were filled with ????
…roduced. See platformio-example.ini, use [env:geiger] to compile in DE, [env:geger_en] for compilation with EN texts Translations not yet fully done (log messages and config page still only in EN, as before)
various smaller fixes
@@ -0,0 +1,52 @@ | |||
/* TR, 07.04.2022 | |||
add new translation strings to ALL files translations_xx.h !!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translations have to work based on the already established workflow we already use for documentation (standard gettext / po files / transifex as nice UI for translators).
do not reinvent the wheel.
and also please do not put something major like this into another pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not reinvent the wheel, this is all (!) ported from the Luftdaten-Sensor project, with some improvements...
This is an ESP32, not a computer, and you really have to tweak the code for memory and size consumption. You have to move this from the heap and put it into flash memory/PROGMEM as much as possible, to get it performing at least somehow. Standard gettext & po files will not really work with an ESP32. I'm not even sure it the macros for po/gettext are available for the ESP platform ( I didn't check this, to be honest).
On the other hand : When else would you need text translations in a web page, if not upon introduction of the pages themselves ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR is way too big and unfocussed IMHO.
it needs to get split up, please start with a PR that ONLY implements the http pages (in English).
no translations, no influxdb.
Readme file adopted with changes in this fork
README_Fork_changes.md added platformio-example.ini updated with IT language
@tw, imo the translation for the embedded pages can differ from the translation for the documentation. |
Da gibt's noch 'ne Baustelle die mir aufgefallen ist, mit den Logleveln: Üblicherweise setzt man loglevel auf 0 und hat keine Ausgabe und je höher der Wert, desto mehr Log wird ausgegeben (so wie im Serial_Print_Mode). Am Ende gehört aber m.E. der Serial_Print_Mode-Zyklus aus log_data.h in die normalen Loglevel überführt ... |
* removed CRITICAL and WARNING as they are not used at all * integrated the second compile time logdata selection behind Serial_Print_Mode --> see log_data.h for details Log-Levels are now NOLOG 0 --> incl. Serial_None, display ALARMS, else turn off logging ERROR 1 --> incl. 0 (=alarms) MIN_INFO 2 --> incl. Serial_Statistics_Log + 0 + 1 MED_INFO 3 --> incl. Serial_One_Minute_Log + 0 + 1 MAX_INFO 4 --> incl. Serial_Logging + 0 + 1 DEBUG 5 --> incl. Serial_Debug + 0 + 1 + 4 That means it is possible to switch the serial log output by changing the log level on the debug page. Be aware that Serial_One_Minute_Log only creates output 1/min. Until then the frame is empty ... * log levels also changed on debug page * rollover messages added on some of the log level buttons * minor fixes
Implements
Purpose is to monitor the current status of the sensor being installed outside, without the necessity to take it back in.
Sensor data can also be monitored with broken Internet connection as long as WLAN is available.
the only prerequisite is to set a build-flag '-DTRANSL_XX', where XX is the language.
see platformio-example.ini for a sample. Languages DE and EN are available already.