-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind max steps and lr iterations #67
Open
Rilwan-Adewoyin
wants to merge
8
commits into
develop
Choose a base branch
from
feat/bind_maxsteps_lriters
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fe3533f
Added max_steps to config and tied training.lr.iterations to max_step…
Rilwan-Adewoyin 07332cd
annotate config with information on how to use max_epochs setting
Rilwan-Adewoyin 2a9398b
update CHANGELOG.md
Rilwan-Adewoyin ef8dbb7
#67 fixed entry in changelog.md
Rilwan-Adewoyin 166fc13
created uniform configurability in config max_steps / max_epochs
Rilwan-Adewoyin 8e17b20
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1c9093c
Merge branch 'develop' into feat/bind_maxsteps_lriters
Rilwan-Adewoyin 1d27b5d
Added note regarding behaviour of scheduler to config
Rilwan-Adewoyin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having this functionality it's great, so thanks @Rilwan-Adewoyin for implementing it!
just a quick question, what happens when/if they user pass both max_steps and max_epochs? will the code then run until max_epochs is reached and the scheduler used the max_steps?
My two cents here is that probably it could be nice to add some logger info to indicate this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks,
So the default pytorch lightning behaviour is that the code will run until the smallest of max_steps or max_epochs is reached, but the scheduler will be aligned to max_steps.
Yep that sounds like a good idea, so add a logger.info message when the user sets both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rilwan-Adewoyin did you have a chance to implement the logger?