-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Stretched graphs #51
Conversation
Co-authored by: Mario Santa Cruz <[email protected]>
Co-authored-by: Mario Santa Cruz <[email protected]>
Co-authored-by: Mario Santa Cruz <[email protected]>
…oi-graphs into 7-local-area-modelling-graphs
* feat: support node masking in edge builder --------- Co-authored-by: Helen Theissen <[email protected]>
Overall this looks really good, and we're pretty much able to reproduce the stretched grid graphs from the old graphgen in aifs-mono. I do have two suggestions:
|
Thanks for taking the time to review the PR.
|
I used unit-max normalization for both enc/dec and proc. The way invert is implemented (length = 1 - length), I would expect this to be done after the edge lengths are normalized to [0,1]. |
The issue should now be resolved. Invert is applied after normalization, and a new method called |
Great! The edge lengths with invert and unit max now look like what I would expect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks very much.
This PR implements the functionality to build stretched graphs only in an area of interest (AOI).
This includes:
Checklist before requesting a review
Issue ticket number and link
Issues #8
This work would not have been possible without @theissenhelen and @JesperDramsch and the rest of the AIFS team! Thanks also to Magnus, Håvard and the MetNorway team for their contributions to this PR.
📚 Documentation preview 📚: https://anemoi-graphs--51.org.readthedocs.build/en/51/